From 92d1b365ce1b4a09ec2406e19e8aea331b9c0dc4 Mon Sep 17 00:00:00 2001
From: allee <allee@lightning.ai>
Date: Mon, 16 Dec 2024 19:44:42 -0500
Subject: [PATCH] Update (ci): github action's artifact upgrade due to EOL for
 versions less than 4

---
 .github/workflows/_build-packages.yml     | 8 +++++---
 .github/workflows/_legacy-checkpoints.yml | 2 +-
 .github/workflows/ci-pkg-install.yml      | 3 ++-
 .github/workflows/docs-build.yml          | 5 +++--
 .github/workflows/release-pkg.yml         | 9 ++++++---
 5 files changed, 17 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/_build-packages.yml b/.github/workflows/_build-packages.yml
index 48f7257674ec6..be6772867e37d 100644
--- a/.github/workflows/_build-packages.yml
+++ b/.github/workflows/_build-packages.yml
@@ -28,7 +28,7 @@ jobs:
       - name: Keep artifact
         id: keep-artifact
         run: python -c "print('DAYS=' + str(5 if '${{ github.event_name }}'.startswith('pull_request') else 0))" >> $GITHUB_OUTPUT
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: ${{ inputs.artifact-name }}
           path: dist
@@ -44,10 +44,11 @@ jobs:
         pkg-name: ${{ fromJSON(inputs.pkg-names) }}
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: ${{ inputs.artifact-name }}
           path: pypi
+          merge-multiple: true
       - uses: actions/setup-python@v5
         with:
           python-version: 3.9
@@ -63,8 +64,9 @@ jobs:
           mkdir pypi/${{ matrix.pkg-name }}
           cp dist/* pypi/${{ matrix.pkg-name }}/
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: ${{ inputs.artifact-name }}
           path: pypi
           include-hidden-files: true
+          overwrite: true
diff --git a/.github/workflows/_legacy-checkpoints.yml b/.github/workflows/_legacy-checkpoints.yml
index b6af39d3313ab..0161ab57bca52 100644
--- a/.github/workflows/_legacy-checkpoints.yml
+++ b/.github/workflows/_legacy-checkpoints.yml
@@ -104,7 +104,7 @@ jobs:
           python -c "print('AWS_RUN=' + str('' if '${{inputs.push_to_s3}}' == 'true' else '--dryrun'))" >> $GITHUB_ENV
 
       - name: Upload checkpoints to GitHub Actions artifact
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: checkpoints-${{ github.sha }}
           path: ${{ env.LEGACY_FOLDER }}/checkpoints/
diff --git a/.github/workflows/ci-pkg-install.yml b/.github/workflows/ci-pkg-install.yml
index 5e772c9546fd7..4c75f67e816cd 100644
--- a/.github/workflows/ci-pkg-install.yml
+++ b/.github/workflows/ci-pkg-install.yml
@@ -50,10 +50,11 @@ jobs:
       - uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: dist-packages-${{ github.sha }}
           path: dist
+          merge-multiple: true
 
       - name: Set package dir
         run: |
diff --git a/.github/workflows/docs-build.yml b/.github/workflows/docs-build.yml
index adbc4613f4ca1..b8a2f699e8393 100644
--- a/.github/workflows/docs-build.yml
+++ b/.github/workflows/docs-build.yml
@@ -129,7 +129,7 @@ jobs:
         run: echo "ARTIFACT_DAYS=7" >> $GITHUB_ENV
       - name: Upload built docs
         if: ${{ matrix.target == 'html' }}
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: docs-${{ matrix.pkg-name }}-${{ github.sha }}
           path: docs/build/html/
@@ -158,10 +158,11 @@ jobs:
       # use input if dispatch or git tag
       VERSION: ${{ inputs.version || github.ref_name }}
     steps:
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: docs-${{ matrix.pkg-name }}-${{ github.sha }}
           path: docs/build/html/
+          merge-multiple: true
 
       - name: Authenticate to Google Cloud
         uses: google-github-actions/auth@v2
diff --git a/.github/workflows/release-pkg.yml b/.github/workflows/release-pkg.yml
index 39f02676305f8..b02d19cd9d887 100644
--- a/.github/workflows/release-pkg.yml
+++ b/.github/workflows/release-pkg.yml
@@ -38,10 +38,11 @@ jobs:
     if: github.event_name == 'release'
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: dist-packages-${{ github.sha }}
           path: dist
+          merge-multiple: true
       - run: ls -lh dist/
       - name: Upload to release
         uses: AButler/upload-release-assets@v3.0
@@ -140,10 +141,11 @@ jobs:
         name: ["FABRIC", "PYTORCH", "LIGHTNING"]
     steps:
       - uses: actions/checkout@v4 # needed for local action below
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: dist-packages-${{ github.sha }}
           path: dist
+          merge-multiple: true
       - name: Browse folder
         id: folder
         run: |
@@ -165,10 +167,11 @@ jobs:
         name: ["FABRIC", "PYTORCH", "LIGHTNING"]
     steps:
       - uses: actions/checkout@v4 # needed for local action below
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: dist-packages-${{ github.sha }}
           path: dist
+          merge-multiple: true
       - name: Browse folder
         id: folder
         run: |