Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Pre-signed GET URL Component/hook #4

Open
macsj200 opened this issue Jan 29, 2017 · 2 comments
Open

Feature Request: Pre-signed GET URL Component/hook #4

macsj200 opened this issue Jan 29, 2017 · 2 comments
Assignees

Comments

@macsj200
Copy link

Hello, I'd like to start off by thanking the maintainers for their hard work on this package. It's a very solid piece of software that has saved me a lot of time 😃.

Would it be possible to add pre-signed URL support? I would like to restrict viewing of files, and the SO question I asked about doing this kind of thing pointed to pre-signed URLs as the way to go.

@Lepozepo You mentioned possibly using Authorizer.S3.getSignedUrl, what might that look like specifically? I'm interested in making a PR for this feature but I don't know where to start.

ping @wesleyfsmith

@MichaelJCole
Copy link

@macsj200 Hey Max, what was your ultimate solution to this?

@Lepozepo
Copy link
Owner

@macsj200 @wesleyfsmith @MichaelJCole I've completely refactored the project and split it into 2 separate packages, one for the client and one for the server (I'll most likely end up splitting the client a little bit more too to remove unused dependencies by the dev). I plan to add signed URLs into an easy to-to-use react component but it should be fairly easy to achieve now using the underlying S3Up.client instance of s3. Sorry for the crazy delay!

@Lepozepo Lepozepo changed the title Pre-signed URL support Feature Request: Pre-signed GET URL Component/hook Sep 27, 2020
@Lepozepo Lepozepo self-assigned this Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants