Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve ABI paths discovery and signature reduction #87

Merged
merged 4 commits into from
Oct 15, 2024
Merged

fix: improve ABI paths discovery and signature reduction #87

merged 4 commits into from
Oct 15, 2024

Conversation

fsamier
Copy link
Contributor

@fsamier fsamier commented Oct 15, 2024

  • Generate array ABI path for array types
  • Move to regex-based substitution rather than incomplete parsing for reduce_signature

First fix is not enough to fix linter issues on https://github.com/LedgerHQ/clear-signing-erc7730-registry/blob/master/registry/paraswap/calldata-AugustusSwapper.json however second fix should allow to progress on LedgerHQ/clear-signing-erc7730-registry#56

@fsamier fsamier added the bug Something isn't working label Oct 15, 2024
@fsamier fsamier requested a review from a team as a code owner October 15, 2024 14:02
jnicoulaud-ledger
jnicoulaud-ledger approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@jnicoulaud-ledger jnicoulaud-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you skip the failing cases so we keep a green CI from now on ?

@fsamier fsamier mentioned this pull request Oct 15, 2024
Merged
@fsamier
Copy link
Contributor Author

fsamier commented Oct 15, 2024

Can you skip the failing cases so we keep a green CI from now on ?

Not needed, CI is green after submodule bump 💪

@fsamier fsamier merged commit 1b4234f into main Oct 15, 2024
5 checks passed
@fsamier fsamier deleted the fix/abi-utils branch October 15, 2024 16:20
@fsamier fsamier mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnicoulaud-ledger jnicoulaud-ledger jnicoulaud-ledger approved these changes

Assignees
No one assigned
Labels
bug Something isn't working sources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsamier @jnicoulaud-ledger