Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABI serialization not symmetric #23

Closed
jnicoulaud-ledger opened this issue Sep 24, 2024 · 0 comments · Fixed by #29
Closed

ABI serialization not symmetric #23

jnicoulaud-ledger opened this issue Sep 24, 2024 · 0 comments · Fixed by #29
Assignees
Labels
bug Something isn't working

Comments

@jnicoulaud-ledger
Copy link
Contributor

Some unset values come back as explicitly set when saving/reloading:

        'abi': [
          {
            'name': 'approve',
            'inputs': [
              {
                'name': '_spender',
                'type': 'address',
              },
              {
                'name': '_value',
                'type': 'uint256',
              },
            ],
            'outputs': [
              {
                'name': '',
                'type': 'bool',
              },
            ],
            'stateMutability': 'nonpayable',
            'type': 'function',
+           'constant': False,
+           'payable': False,
          },

Must use bool | None = None to preserve difference between "set to default value" and "unset"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants