From 9c4dd5a772258d2f6b2f3590f30f5da7fbbe3194 Mon Sep 17 00:00:00 2001 From: Louis Aussedat Date: Wed, 15 Jan 2025 17:34:46 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=A9=B9=20(signer-eth):=20Add=20user=20int?= =?UTF-8?q?eraction=20during=20provide?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .changeset/funny-rockets-glow.md | 5 +++++ .../SignTypedData/SignTypedDataDeviceAction.test.ts | 8 ++++---- .../SignTypedData/SignTypedDataDeviceAction.ts | 10 ++++++++++ 3 files changed, 19 insertions(+), 4 deletions(-) create mode 100644 .changeset/funny-rockets-glow.md diff --git a/.changeset/funny-rockets-glow.md b/.changeset/funny-rockets-glow.md new file mode 100644 index 000000000..404695dee --- /dev/null +++ b/.changeset/funny-rockets-glow.md @@ -0,0 +1,5 @@ +--- +"@ledgerhq/device-signer-kit-ethereum": patch +--- + +Add user interraction for sign typed object device action that was removed before diff --git a/packages/signer/signer-eth/src/internal/app-binder/device-action/SignTypedData/SignTypedDataDeviceAction.test.ts b/packages/signer/signer-eth/src/internal/app-binder/device-action/SignTypedData/SignTypedDataDeviceAction.test.ts index eab8fbc72..a0611a446 100644 --- a/packages/signer/signer-eth/src/internal/app-binder/device-action/SignTypedData/SignTypedDataDeviceAction.test.ts +++ b/packages/signer/signer-eth/src/internal/app-binder/device-action/SignTypedData/SignTypedDataDeviceAction.test.ts @@ -167,7 +167,7 @@ describe("SignTypedDataDeviceAction", () => { }, { intermediateValue: { - requiredUserInteraction: UserInteractionRequired.None, + requiredUserInteraction: UserInteractionRequired.SignTypedData, }, status: DeviceActionStatus.Pending, }, @@ -277,7 +277,7 @@ describe("SignTypedDataDeviceAction", () => { }, { intermediateValue: { - requiredUserInteraction: UserInteractionRequired.None, + requiredUserInteraction: UserInteractionRequired.SignTypedData, }, status: DeviceActionStatus.Pending, }, @@ -437,7 +437,7 @@ describe("SignTypedDataDeviceAction", () => { }, { intermediateValue: { - requiredUserInteraction: UserInteractionRequired.None, + requiredUserInteraction: UserInteractionRequired.SignTypedData, }, status: DeviceActionStatus.Pending, }, @@ -504,7 +504,7 @@ describe("SignTypedDataDeviceAction", () => { }, { intermediateValue: { - requiredUserInteraction: UserInteractionRequired.None, + requiredUserInteraction: UserInteractionRequired.SignTypedData, }, status: DeviceActionStatus.Pending, }, diff --git a/packages/signer/signer-eth/src/internal/app-binder/device-action/SignTypedData/SignTypedDataDeviceAction.ts b/packages/signer/signer-eth/src/internal/app-binder/device-action/SignTypedData/SignTypedDataDeviceAction.ts index 539eae3e9..592d33e61 100644 --- a/packages/signer/signer-eth/src/internal/app-binder/device-action/SignTypedData/SignTypedDataDeviceAction.ts +++ b/packages/signer/signer-eth/src/internal/app-binder/device-action/SignTypedData/SignTypedDataDeviceAction.ts @@ -195,6 +195,16 @@ export class SignTypedDataDeviceAction extends XStateDeviceAction< }, }, ProvideContext: { + entry: assign({ + intermediateValue: { + requiredUserInteraction: UserInteractionRequired.SignTypedData, + }, + }), + exit: assign({ + intermediateValue: { + requiredUserInteraction: UserInteractionRequired.None, + }, + }), invoke: { id: "provideContext", src: "provideContext",