Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every armor in Starfinder is also a light source #62

Open
Beff42 opened this issue Sep 30, 2023 · 1 comment
Open

Every armor in Starfinder is also a light source #62

Beff42 opened this issue Sep 30, 2023 · 1 comment
Labels
enhancement New feature or request investigate Issue needs me to look into it

Comments

@Beff42
Copy link

Beff42 commented Sep 30, 2023

By default every armor in Starfinder has a flashlight attached. There are probably 100 or more suits of armor in the game. I could just add all of them into the source file, but I am not sure, if this is intended.
Another possibility would be to extend the library.js to being able to understand a category or list of items, so all items of a certain type (here armor) can have the same light source.
The default light configuration is currently serving as a workaround, but it's not really solving this, since not all actors wear armor.

I might be down to open a PR for either option above, just let me know which you prefer.

@lupestro
Copy link
Collaborator

There is the notion of an alias, which takes up less space than a full-fledged definition. Even so, adding that many would be daunting. I'll have to think on this one.

@lupestro lupestro added enhancement New feature or request investigate Issue needs me to look into it labels Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request investigate Issue needs me to look into it
Projects
None yet
Development

No branches or pull requests

2 participants