Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Position mismatch (offset) at the client after moving or flipping #180

Open
Oxy949 opened this issue Dec 12, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@Oxy949
Copy link
Contributor

Oxy949 commented Dec 12, 2024

Module Version: v2.9.3

Describe the bug
After the actor appears on the stage, his position is synchronized between clients, i.e. everyone has the lower left corner of the portrait in the lower left corner of the screen. However, if you modify the position of the portrait, including flip (using mouse), the gamemaster's one stays fine, but the clients' portrait now has a permanent offset.

If you look closely at the debug screenshot, you can notice that the portraitContainer (XPos / YPos) has changed, however original picture has not moved. After the first change, the offset exists until actor dismissed.

My module settings:

  • allow control: gm only
  • max portrait size: 700px
  • Others: default

To Reproduce
Steps to reproduce the behavior:

  1. Launch a world with a gamemaster and a player. They must be logged in from different devices to reproduce the issue.
  2. Create a new character, change the character's theatre portrait to png 2048x2048px
  3. Set allow control: gm only, max portrait size: 700px in module settings
  4. Show any actor on stage, it should appear on client
  5. Move actor on stage or flip, now the client's version of the actor have an offset

Expected behavior
The client's version of the actor must be consistent with gamemaster's one

Screenshots
Console:
Screenshot 2024-12-12 222919

Actor on client before gamemaster's flip:
Screenshot 2024-12-12 222248

And after:
Screenshot 2024-12-12 222310

Browser:
Tested on Chrome, Firefox

Foundry Version: 12.331

Game System: DnD 5e 4.1.2

Additional context
Ping me if you need more info or tests.

@Oxy949 Oxy949 added the bug Something isn't working label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant