-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module breaks PF2e system's chat card buttons #120
Comments
Foundry Version 10 Build 291 |
yes same Issue, after deactivating the PF2e Buttons work again. |
I don't know if anyone is even still updating this, but in the off chance people are running into this issue, I've managed to fix it myself by going into the theatre_main.js file and removing line 225: "actor: null" I've got Theatre ignoring chat messages for now in settings, and primarily use it for presentation of NPCs, so ymmv. |
The fix needs to be made in theatre_main.js at line 232.
so that it looks like
Additional optimisation is to remove the test for |
This appears to fix the issue. Woohoo! Thanks again! |
It looks like some other systems break unless you do the fix for line 225. For example, the new crucible system occassionally has chat button issues. It seems like this is the case with 5e as well. I'll be pushing an update soon with the line 225 fix, but if runs into issues, I'll un-comment it. |
Any updates on this? Running into this issue at the moment, so I'm guessing it hasn't gone through yet. |
Are you on v2.8.0? If you are on forge, theres a chance it might not have pulled the updates. |
Foundry Version 10 Build 291
PF2e Version 4.11.1
No other modules installed.
No other systems tested.
When Theatre Inserts is active, PF2e's in-built chat card buttons no longer function (such as for rolling damage).
The problem persists so long as Theatre Inserts was active when the chat card was created, even when disabled the chat card will remain broken.
Likewise chat cards created before the module is activated will continue to work once the module is active.
The text was updated successfully, but these errors were encountered: