Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title attributes to sidebar ID buttons #24

Open
arcanistzed opened this issue Oct 16, 2021 · 2 comments
Open

Add title attributes to sidebar ID buttons #24

arcanistzed opened this issue Oct 16, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@arcanistzed
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It may not be immediately clear what the buttons do and it is not very accessible if using a screen reader.

Describe the solution you'd like
Title attributes would be added: "Copy ID" and "Print ID"

@arcanistzed arcanistzed added the enhancement New feature or request label Oct 16, 2021
@akrigline akrigline added good first issue Good for newcomers and removed enhancement New feature or request labels Oct 16, 2021
@akrigline
Copy link
Member

Good idea, I'll admit i'm not overly concerned about accessiblity on this module as it is an extremely niche tool for non-"users." But a title attribute never hurt anyone. Ensure it's localized as well :).

@akrigline akrigline added the enhancement New feature or request label Oct 16, 2021
@mkahvi
Copy link
Contributor

mkahvi commented Sep 28, 2022

With v10 these probably should be data-tooltip="blah" instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants