Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Document Namespace Helper Types #2994

Open
LukeAbby opened this issue Dec 22, 2024 · 3 comments
Open

More Document Namespace Helper Types #2994

LukeAbby opened this issue Dec 22, 2024 · 3 comments

Comments

@LukeAbby
Copy link
Collaborator

The now deprecated ConfiguredSheetClass, ObjectClass, and LayerClass are all being namespaced.

It'd be helpful to have stuff like Item.SheetClass or AmbientLight.LayerClass.

There's some redundancy here too. It'd also make sense on AmbientLightLayer.ConfiguredClass etc.

@LukeAbby LukeAbby changed the title More Helper Types More Document Namespace Helper Types Dec 22, 2024
@JPMeehan
Copy link
Collaborator

For what it's worth I don't think configured sheet class is helpful because it's too easy for end users to change from expected.

@LukeAbby
Copy link
Collaborator Author

That's true. Do you think we should deprecate the ability to get that from the configuration? It is kind of a legacy thing.

I suppose it might be better to just do typeof YourConfiguredClass | typeof GenericSheetClass like we do for document.type.

@JPMeehan
Copy link
Collaborator

I'm eh on if it's useful at all to be honest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants