Convert CONST properties to Branded types where appropriate

[esheyw]

Lots of properties in CONST are currently in the form

export declare const ENUM_NAME: Readonly<{
  prop1: T;
  prop2: T;
}>
export type ENUM_NAME = ValueOf<typeof ENUM_NAME>

The repo has been moving towards using the new Brand type like so:

export type ENUM_NAME: Brand<T, "Namespace.ENUM_NAME">
export declare const ENUM_NAME: Readonly<Record<"prop1" | "prop2", ENUM_NAME>>;

This works for properties that are already effectively Record<string, T>, but I am not sure what we want to do with arrays. There's maybe value in preserving the literal values of things like CONST.WORLD_DOCUMENT_TYPES, etc.

[JPMeehan]

The various arrays have a lot of value in not collapsing to string

[LukeAbby]

Yeah I probably would recommend not converting arrays. They can act like pseudo-enums but you're supposed to refer to them by value. Going around and doing WORLD_DOCUMENT_TYPES[3] would be silly, just write "Combat".