Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look At All Usages of FormInputConfig<unknown> #2917

Open
LukeAbby opened this issue Nov 6, 2024 · 1 comment
Open

Look At All Usages of FormInputConfig<unknown> #2917

LukeAbby opened this issue Nov 6, 2024 · 1 comment
Labels
foundry v12 This belongs to Foundry VTT version 12 good first issue Good for newcomers

Comments

@LukeAbby
Copy link
Collaborator

LukeAbby commented Nov 6, 2024

In the 2808-fields branch which as of this date is yet to be merged, I made the generic parameter of FormInputConfig required because I suspected that every usage sites should really be specifying the generic.

This has left some uses of FormInputConfig<unknown> because I didn't look into what the valid values were.

@LukeAbby LukeAbby added good first issue Good for newcomers foundry v12 This belongs to Foundry VTT version 12 labels Nov 6, 2024
@dylanpiera
Copy link
Contributor

Valid types appear to be:

  • boolean (BooleanField)
  • string (StringField)
  • string[] (StringField <multi-select>)
  • number (NumberField)

Foundry itself marks it as *, if someone is to make their own custom fields, any value should be accepted, so at the end of the day this needs to have some kind of any support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
foundry v12 This belongs to Foundry VTT version 12 good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants