Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering translated spells by class #18

Open
eduardopato41 opened this issue Jun 18, 2021 · 3 comments
Open

Filtering translated spells by class #18

eduardopato41 opened this issue Jun 18, 2021 · 3 comments

Comments

@eduardopato41
Copy link

Hi! I wanted to use your module to facilitate the process of adding new spells to my players' characters. Sadly, I created all phb spells in Brazilian Portuguese (using the official translated book) and nothing shows when filtering by CLASS. I believe the "spell-classes.json" are responsible for this, right? Is this something I can add this to the "pt-BR.json" on "lang" (to retain this changes over updates and stuff)? How should I add them for this to work? Or do I need to edit "spell-classes.json" directly? Thanks!

PS.: I don't know if this qualify as a issue but I could really use some help. I'm not a dev so i'm kinda lost :(

@eduardopato41 eduardopato41 changed the title Filtering translated spells Filtering translated spells by class Jun 18, 2021
@spetzel2020
Copy link
Collaborator

I'm sorry to only just see this; I realized my notifications were off because it's in the League's github.

Yes, spell-classes.json is the hacked way that CB does filtering by class (I guess this information is not easily accessible otherwise). Unfortunately I don't think adding anything to the lang file will help, because that's not consulted for classes.

You are welcome to hack this yourself for your install, but I am going to see if there's a better way of doing this long-term. Not just the language issue, but that new spells (like from Tasha's) are not currently included.

@eduardopato41
Copy link
Author

No worries. I'm still adding all monsters from the Monster Manual! After that I will hack this solution haha
Thanks for replying. And thank you, this module is awesome and exactly what I needed!

@GMToolbox
Copy link

I know this is an old issue but its something that has cropped up for me as a content creator for some larger 3rd party publishers. They have custom spells in their content and users want to be able to sort them. I had a thought on a solution. Its not the greatest but it could work.
The content creator can create a json in the same format you use for the SRD spells for their own spells. Then you can create an import tool in Compendium Browser that can be pointed to the JSON file and the spells would be imported into Compendium Browser. My thought is it would simply copy all of the new spells into your existing json file. This would prevent you from having to add additional lines of code into the js file when they import. Its just additional data in the json. They would have to reimport every time there is an update to Compendium Browser which is unfortunate but it seems a small price to pay for the convenience of the feature. Hope its something you can add at some point. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants