Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in miscentering when mass def=critical and mis_from_backend=False #660

Closed
combet opened this issue Feb 5, 2025 · 1 comment · Fixed by #662
Closed

Bug in miscentering when mass def=critical and mis_from_backend=False #660

combet opened this issue Feb 5, 2025 · 1 comment · Fixed by #662
Assignees
Labels
bug Something isn't working priority Essential for current milestone

Comments

@combet
Copy link
Collaborator

combet commented Feb 5, 2025

When mis_from_backend=False (i.e., we do some of the miscentering integrations in CLMM rather than relying on the backend), having massdef = critical is ignored and the output always corresponds to massdef = mean.

I just had quick look but I believe this might come from the function below in parent_class.py in theory, where get_rho_m is called in all cases, without checking for what massdef is.

        def _miscentering_params(self, z_cl, mis_from_backend):
        params = None
        if mis_from_backend:
            params = 1, (z_cl,)

        else:
            rho_def = self.cosmo.get_rho_m(z_cl)
            r_s = self.eval_rdelta(z_cl) / self.cdelta
            ...

Pinging @hsinfan1996, @m-aguena

@combet combet added bug Something isn't working priority Essential for current milestone labels Feb 5, 2025
@combet combet changed the title Bug in miscentering when mass def is "critical" and mis_from_backend=False Bug in miscentering when mass def=critical and mis_from_backend=False Feb 5, 2025
@m-aguena
Copy link
Collaborator

m-aguena commented Feb 5, 2025

@combet good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority Essential for current milestone
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants