Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split test fixtures in test_filter_metadata.py #166

Open
ilumsden opened this issue Jun 3, 2024 · 0 comments
Open

Split test fixtures in test_filter_metadata.py #166

ilumsden opened this issue Jun 3, 2024 · 0 comments
Labels
area-tests Issues and PRs involving Thicket's automated tests priority-normal Normal priority issues and PRs type-internal-cleanup PRs or Issues related to the structure of the codebase, directories, and refactors

Comments

@ilumsden
Copy link
Collaborator

ilumsden commented Jun 3, 2024

Minor issue that cropped up in the review of #164.

In test_filter_metadata.py, there are the following 3 functions:

  • filter_one_column
  • filter_multiple_and
  • filter_multiple_or

These functions are essentially test fixtures, but, instead of being treated as fixtures, they are just functions that are combined into one fixture called test_filter_metadata. As a result of having this "super-fixture", we can't easily detect which of the 3 functions above actually failed.

This "super-fixture" should be split into 3 different fixtures to test these functions independently and simplify failure tracking.

Additionally, per the discussion in #164, these functions are (for some reason) also used in:

  • thicket/tests/test_concat_thickets.py
  • thicket/tests/test_groupby.py

As a result, these functions should be moved into some "testing utils" module. Then, test_filter_metadata.py should import the functions and use them in the 3 new fixtures, and the other two modules (listed above) should import the functions and use them as they currently are.

@ilumsden ilumsden added area-tests Issues and PRs involving Thicket's automated tests priority-normal Normal priority issues and PRs type-internal-cleanup PRs or Issues related to the structure of the codebase, directories, and refactors labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-tests Issues and PRs involving Thicket's automated tests priority-normal Normal priority issues and PRs type-internal-cleanup PRs or Issues related to the structure of the codebase, directories, and refactors
Projects
None yet
Development

No branches or pull requests

1 participant