Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFlotran engine needs to be updated to a more recent version #17

Open
jeff-cohere opened this issue Jan 9, 2016 · 5 comments
Open

PFlotran engine needs to be updated to a more recent version #17

jeff-cohere opened this issue Jan 9, 2016 · 5 comments

Comments

@jeff-cohere
Copy link

The version of the PFlotran reaction library we're using is now quite old, and uses an older version of PETSc (3.5 instead of 3.6). Moreover, it looks like an odd interaction between Alquimia and that version of PFlotran prevents shared library builds of Alquimia from working properly (see #16).

We need to establish a newer version of the reaction library to link against (hopefully a release instead of a hash of pflotran-dev) and modify the Alquimia PFlotran engine code accordingly, making sure that shared library builds work on Mac and Linux.

@jeff-cohere
Copy link
Author

After talking with Glenn, who says that the chemistry interface has been stable for a while, I think we should target PFlotran commit cfa0b8d (the HEAD of the repo at the time of this message).

@smolins
Copy link
Collaborator

smolins commented Jan 20, 2016

I am ok with upgrading the pflotran interface. I believe this would also involve updating the input files of the tests. As far as Petsc 3.6, I would like to make sure that Crunch also works with 3.6 so that we don't have to deal with two petsc's for Alquimia.

@jeff-cohere
Copy link
Author

Ok. I haven't prioritized this yet, but it's likely that I could produce an updated version of the PFlotran engine before the IDEAS xSDK release in February. If/when you get a chance to test Crunch with PETSc 3.6, just let me know if you run into any issues, and I'll be happy to help out.

@smolins
Copy link
Collaborator

smolins commented Jan 20, 2016

There are branches that work with petsc 3.6. It is trivial for crunch, but
I would need to check whether Carl has updated his branch, which I am
tracking for Alquimia.

On Wed, Jan 20, 2016 at 9:56 AM, Jeffrey Johnson [email protected]
wrote:

Ok. I haven't prioritized this yet, but it's likely that I could produce
an updated version of the PFlotran engine before the IDEAS xSDK release in
February. If/when you get a chance to test Crunch with PETSc 3.6, just let
me know if you run into any issues, and I'll be happy to help out.


Reply to this email directly or view it on GitHub
#17 (comment)
.

@jeff-cohere
Copy link
Author

This is less urgent than it was before. Alquimia now works with the 3.6 and development versions of PETSc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants