Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamline interface between wav_set and psi #11

Open
svdavid opened this issue Jan 24, 2024 · 1 comment
Open

streamline interface between wav_set and psi #11

svdavid opened this issue Jan 24, 2024 · 1 comment
Assignees

Comments

@svdavid
Copy link
Contributor

svdavid commented Jan 24, 2024

wav_set (and subclasses) should be modified to make explicit what parameters should be user-defined in the psi interface.

For complex wav_sets (which have children) collapse all user parameters into a single list(?)

parameters should be specified in a list of dictionaries... indicating (variable name, text label, variable type, default value)

@svdavid svdavid self-assigned this Jan 24, 2024
@svdavid
Copy link
Contributor Author

svdavid commented Jun 10, 2024

seems to be resolved now in the new_parameters branch.

wav_set classes should define a default_params dictionary, which is used to general the enaml structures for the UI. FgBgSet provides the model format. Implemented and tested in VGN. Still pending for CAT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant