Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise plots in nems.visualization.model #1

Open
jacobpennington opened this issue Sep 8, 2022 · 1 comment
Open

Revise plots in nems.visualization.model #1

jacobpennington opened this issue Sep 8, 2022 · 1 comment
Assignees
@svdavid @jacobpennington
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@jacobpennington
Copy link
Collaborator

Currently a duplicate version of plot_model (plot_model_with_parameters) that includes extra features. Merge these and/or separate out the repeated code, update Layer.plot scheme if needed.
@jacobpennington jacobpennington added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 8, 2022
@jacobpennington
Copy link
Collaborator Author

Proposed solution: rename plot_model_with_parameters to plot_LN and make it clear that it assumes a specific model structure. This should simplify the code quite a bit. I don't want plot_model_with_parameters to devolve into another iteration of the old quickplot code with a maze of if/else chains for every possible layer combination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svdavid svdavid

@jacobpennington jacobpennington

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@svdavid @jacobpennington