From ee39a69407616d2fdf8f4c52e3f70192eaf1768b Mon Sep 17 00:00:00 2001 From: elliotxx <951376975@qq.com> Date: Fri, 17 May 2024 18:17:50 +0800 Subject: [PATCH] fix: wrong release workflow as dirty git state (#433) ## What type of PR is this? /kind bug ## What this PR does / why we need it: fix wrong release workflow as dirty git state --- .github/workflows/release.yaml | 1 + .gitignore | 2 ++ Makefile | 2 +- ui/.gitignore | 2 -- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 75d2fdc7..fad2c204 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -113,6 +113,7 @@ jobs: # It bypasses the 'process.env.CI = true' setting in CI environments # that treats warnings as errors, ensuring a successful build. CI=false npm run build + touch build/.gitkeep - name: Release the karpor with GoReleaser uses: goreleaser/goreleaser-action@v2 diff --git a/.gitignore b/.gitignore index 176795a3..9784287f 100644 --- a/.gitignore +++ b/.gitignore @@ -39,6 +39,8 @@ __debug_bin # build dist/ build/ +ui/build/* +!ui/build/.gitkeep _build/ # log diff --git a/Makefile b/Makefile index 7262ef4c..4931b5c6 100644 --- a/Makefile +++ b/Makefile @@ -138,7 +138,7 @@ build-server-windows: ## Build server for Windows .PHONY: build-ui build-ui: ## Build UI for the dashboard @echo "Building UI for the dashboard ..." - cd ui && npm install && npm run build + cd ui && npm install && npm run build && touch build/.gitkeep .PHONY: check-license check-license: ## Checks if repo files contain valid license header diff --git a/ui/.gitignore b/ui/.gitignore index 89ed2a91..c9c9b2c8 100644 --- a/ui/.gitignore +++ b/ui/.gitignore @@ -21,7 +21,5 @@ /config/config.local.ts /yarn.lock /.nyc_output -/build .DS_Store /src/.DS_Store -