Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: KryptonCustomPaletteBase, Unable to Set / Change the colour table (help to migrate to v90.) #1870

Open
lesandrog opened this issue Nov 19, 2024 · 9 comments
Labels
area:documentation All issues related to documentation. area:themes All things to do with themes. bug Something isn't working regression Something was working in a previous release, but isn't working now. version:95 All things to do with V95. version:100 All things to do with V100.

Comments

@lesandrog
Copy link

In version 85, I was using a KryptonCustomPaletteBase with BasePaletteMode = Office2010Silver, with some modifications.

But I'm not able to migrate to v90.

I must be doing something wrong.
image

@lesandrog lesandrog added the question Further information is requested label Nov 19, 2024
@lesandrog
Copy link
Author

Can anyone help me?

@lesandrog lesandrog changed the title [Question]: KryptonCustomPaletteBase, help to migrate to v90 [Question]: KryptonCustomPaletteBase, help to migrate to v90. Dec 13, 2024
@PWagner1
Copy link
Contributor

Hi @lesandrog

The KryptonCustomPaletteBase has gone through a significant overhaul in V90. You may need to set the BasePaletteType located under BasePalette, see https://github.com/Krypton-Suite/Standard-Toolkit?tab=readme-ov-file#v9000-2024-11-12---build-2411---november-2024 for breaking changes.

@PWagner1 PWagner1 added the awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. label Dec 13, 2024
@lesandrog
Copy link
Author

Hi @PWagner1

When I add the KryptonManager and set GlobalCustomPalette = KryptonCustomPaletteBase1.
I set in KryptonCustomPaletteBase1.BasePaletteType = Office2010

The colors are still Microsoft 365 - Blue.

In BasePaletteType, should there be more options (Office 2010 - Silver, Office 2010 - White)?
image

@PWagner1
Copy link
Contributor

@Smurf-IV ??

@Smurf-IV
Copy link
Member

In BasePaletteType, should there be more options (Office 2010 - Silver, Office 2010 - White)?

No it BaseRenderMode, and this has nothing to do with the colours, as they are defined in the actual XML.

The colors are still Microsoft 365 - Blue.

The default colours come from the BasePalette's ColourTable:
image
(Defined in the XML? @PWagner1 )
And then are overridden by the extra colours as defined in the actual custom palettes XML or defined in the designer

@lesandrog
Copy link
Author

hi, @PWagner1 and @Smurf-IV

So, from what I understand, to use KryptonCustomPaletteBase1 with the Office 2010 - Silver colors and some customizations (or if you want to customize another theme), I will have to import a complete XML with all the parameters.

In my humble opinion, it is not very practical.
Or I don't know how to use it.

@Smurf-IV
Copy link
Member

In my humble opinion, it is not very practical.

Agreed!
The colour Table stuff does not appear to change anymore like it used to in the V8# code base:
image

@Smurf-IV Smurf-IV added bug Something isn't working area:themes All things to do with themes. regression Something was working in a previous release, but isn't working now. area:documentation All issues related to documentation. version:100 All things to do with V100. version:95 All things to do with V95. and removed question Further information is requested awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. labels Dec 18, 2024
@Smurf-IV Smurf-IV changed the title [Question]: KryptonCustomPaletteBase, help to migrate to v90. [Bug]: KryptonCustomPaletteBase, Unable to Set / Change the colour table (help to migrate to v90.) Dec 18, 2024
@Smurf-IV
Copy link
Member

@lesandrog Can you open your V80 xml and just change the version number to 20.
Does this then work as expected ?

@lesandrog
Copy link
Author

@Smurf-IV , I had already done this test of changing v19 to v20. The result is partial, the colors that are in the custom xml are loaded correctly, but items that are not present in the xml continue with the default Microsoft365blue colors.

image In Palette Designer v85, creating a new one with BasePaletteMode, the theme colors were loaded. In v90 using BaseRenderMode the colors remain the same as 365blue.
.

image When importing a custom XML, only the custom items are changed, the other items continue with the default theme colors, microsoft365blue.
.

image The best result was to export an xml after using the "Populate from base" function in a v85 project and then use it in v90.
This way all the colors of the BasePalettemode are exported.
I am using the Office2010silver theme, but it is the same for other themes.
.

image One disadvantage of using the "Populate from Base" function in a v85 project is that in some themes, some items are not populated, such as ToolMenuStatus. Manual editing is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:documentation All issues related to documentation. area:themes All things to do with themes. bug Something isn't working regression Something was working in a previous release, but isn't working now. version:95 All things to do with V95. version:100 All things to do with V100.
Projects
None yet
Development

No branches or pull requests

3 participants