Run OhMyREPL keybindings in a fixed world age #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should avoid most invalidations caused by loading other packages. Also remove the NEW_KEYBINDINGS global as it's hard to follow where this is added to. Rearrange all overrides so the implementation code can be precompiled, with the only thing which is `eval`d at runtime being the method pirating itself. Include global mutable "hook" binding for `LineEdit.refresh_line` to allow us to fix the world age of the implementation.
|
Yeah at this point it feels to me the window CI is unrelated and apparently Documenter.jl?? Will investigate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-proposal of #321 which apparently needed to be reverted due to (unrelated??) issues with the windows test harness.
CC @Moelf