-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to disable auto double quotes matching #346
base: master
Are you sure you want to change the base?
Add ability to disable auto double quotes matching #346
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #346 +/- ##
==========================================
- Coverage 56.27% 56.18% -0.09%
==========================================
Files 15 15
Lines 1123 1123
==========================================
- Hits 632 631 -1
- Misses 491 492 +1 ☔ View full report in Codecov by Sentry. |
I hope this pull request will be processed very soon since this is a good idea. I just want to disable the autocompletion of " mark but want to keep the autocompletion of brackets! |
Just want to comment on the possibility of adding an option to disable autocompletion of single quotes ( |
I am not sure if this needs to be an option. I would rather have it disabled by default and reduce configuration complexity. |
Imo, the first thing to do is to only add the option (with docs) etc. That is uncontroversial. Then the question of what the default should be can be discussed. |
This creates a workaround for #334. On Julia 1.10 and later the default is to disable OhMyREPL's matching of string literal delimiters (a.k.a double quotes
"
) , and this can be manually done on any Julia version withenable_autocomplete_string_literals(false)
, which is exported as with the existingenable_autocomplete_brackets
.