[Core] Consistency between Element/Condition and Node clone

[loumalouomega]

The clone of the node does not consider new Id:

Kratos/kratos/includes/node.h

Line 328 in fbb7be7

typename Node<TDimension>::Pointer Clone()

But the condition and element does:

Kratos/kratos/includes/element.h

Line 233 in 231a4d1

virtual Pointer Clone (IndexType NewId, NodesArrayType const& ThisNodes) const

Maybe we should discuss this inconsistency

[loumalouomega]

I think this discussion is still valid

[loumalouomega]

I think this discussion is still valid

@KratosMultiphysics/technical-committee

[roigcarlo]

@loumalouomega We are currently considering options to "merge" elements and conditions. As long as the PR is ready we will ping everyone.

In the meantime, I agree with you, its odd that they have different interfaces :S

[loumalouomega]

@loumalouomega We are currently considering options to "merge" elements and conditions. As long as the PR is ready we will ping everyone.

In the meantime, I agree with you, its odd that they have different interfaces :S

It is nice to unify elements and conditions, as implementation is 99.9% identical. In any case, this discussion is still valid.

[pooyan-dadvand]

@KratosMultiphysics/technical-committee don't see any reason for having the Clone method for the node as we don't derive from it. So we propose to remove the Clone of the node (and implicitly we don't have inconsistency anymore)

[RiccardoRossi]

@loumalouomega is this still a relevant PR in view of eventually removing the clone of the node?

[loumalouomega]

There is a PR, where this is discussed as well

[loumalouomega]

There is a PR, where this is discussed as well

#11286

(@RiccardoRossi you contributed recently there)