Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StructMech] make primal element member private in FD adjoint elements #4386

Open
armingeiser opened this issue Mar 8, 2019 · 1 comment
Assignees

Comments

@armingeiser
Copy link
Member

A general comment to adjoint elements/conditions which does not belong directly to this PR but In my eyes worth to mention: During my review I observed a nonuniform usage of the pointer of the primal element. Sometimes the member variable is directly used, sometimes the function pGetPrimalElement is used. And I don't understand why the function pGetPrimalElement is needed since the pointer to the primal element/condition is a protected member variable. Of course this is only a minor detail and not part of this PR but I was just wondering.

If you make the pointer a private member then you can only access it via the Get-Function
This could also avoid unintended uses if you want to make some restrictions

Originally posted by @philbucher in #4338 (comment)

@armingeiser armingeiser self-assigned this Mar 8, 2019
@philbucher
Copy link
Member

is this solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants