Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change README gradle import syntax #197

Open
Sternbach-Software opened this issue Nov 30, 2022 · 5 comments
Open

Change README gradle import syntax #197

Sternbach-Software opened this issue Nov 30, 2022 · 5 comments

Comments

@Sternbach-Software
Copy link
Contributor

Sternbach-Software commented Nov 30, 2022

Replace implementation group: 'com.kosherjava', name: 'zmanim', version: '2.4.0' with implementation 'com.kosherjava:zmanim:2.4.0

@elijulian
Copy link
Contributor

I think that this is a matter of taste, if you prefer this syntax maybe open a pull request to change it

@elijulian
Copy link
Contributor

Definitely not a bug

@Sternbach-Software
Copy link
Contributor Author

@elijulian Seems to cause bugs: #198 (comment)

@elfifo4
Copy link
Contributor

elfifo4 commented Jun 26, 2023

Hi @elijulian
it's not just a matter of taste
in build.gradle.kts of KMM project (Kotlin Multiplatform Mobile), it doesn't compile.
so this syntax is really needed:
implementation("com.kosherjava:zmanim:2.5.0")

relevant PR:
#210

Screen Shot 2023-06-26 at 15 42 10

@elijulian
Copy link
Contributor

Hi @elijulian it's not just a matter of taste in build.gradle.kts of KMM project (Kotlin Multiplatform Mobile), it doesn't compile. so this syntax is really needed: implementation("com.kosherjava:zmanim:2.5.0")

relevant PR: #210

Screen Shot 2023-06-26 at 15 42 10

fascinating, i didn't realize that it was required by any platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants