Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Kong/node-libcurl
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.31.3
Choose a base ref
...
head repository: Kong/node-libcurl
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: develop
Choose a head ref
5 contributors

Commits on Nov 21, 2024

  1. feat: enable legacy openssl providers + weak ciphers support (#69) 

    * spike: legacy openssl providers

* enable weak ciphers
    @filfreire
    filfreire authored Nov 21, 2024
    Copy the full SHA
    860733d View commit details

  2. 2.31.4-alpha.0

    @filfreire
    filfreire committed Nov 21, 2024
    Copy the full SHA
    8be416b View commit details

  3. Revert "feat: enable legacy openssl providers + weak ciphers support (#… 

    …69)"

This reverts commit 860733d.
    @filfreire
    filfreire committed Nov 21, 2024
    Copy the full SHA
    4b316bc View commit details

Commits on Nov 22, 2024

  1. fix: localhost resolution RFC6761 (#70) 

    * spike: investigate localhost resolution RFC6761

* bump curl to 7.85.0

* fix

* pull latest curl-for-windows & bump to 7.86.0
    @filfreire
    filfreire authored Nov 22, 2024
    Copy the full SHA
    fb41cb2 View commit details

  2. 2.31.4

    @filfreire
    filfreire committed Nov 22, 2024
    Copy the full SHA
    898afe8 View commit details

Commits on Nov 26, 2024

  1. feat: enable-legacy and enable-weak-ssl-ciphers (#71) 

    * enable-legacy and enable-weak-ssl-ciphers

* update dependency
    @notjaywu
    notjaywu authored Nov 26, 2024
    Copy the full SHA
    27217e7 View commit details

  2. 2.31.5-alpha.0

    @filfreire
    filfreire committed Nov 26, 2024
    Copy the full SHA
    4c18044 View commit details

  3. chore: switch curl-for-windows fork (#72) 

    * chore: switch curl-for-windows fork

* bump curl-for-windows submodule commit
    @filfreire
    filfreire authored Nov 26, 2024
    Copy the full SHA
    6e86348 View commit details

  4. 2.31.5-alpha.1

    @filfreire
    filfreire committed Nov 26, 2024
    Copy the full SHA
    1344893 View commit details

Commits on Jan 9, 2025

  1. Bump-electron-33 (#75) 

    * bump 33

* use latest autoconf?

* use c++20

* bump nan

* postinstall hack

* nan patch

* move before pre gyp
    @jackkav
    jackkav authored Jan 9, 2025
    Copy the full SHA
    ed8626b View commit details

  2. 2.33.0

    @filfreire
    filfreire committed Jan 9, 2025
    Copy the full SHA
    def9d85 View commit details

  3. fix: github-actions (#78)

    @filfreire
    filfreire authored Jan 9, 2025
    Copy the full SHA
    2af5181 View commit details

  4. 2.33.1

    @filfreire
    filfreire committed Jan 9, 2025
    Copy the full SHA
    00bb9a3 View commit details

  5. hotfix: try to force permissions for write-all

    @filfreire
    filfreire committed Jan 9, 2025
    Copy the full SHA
    ff9b364 View commit details

  6. hotfix: try to force permissions for write-all for new-version

    @filfreire
    filfreire committed Jan 9, 2025
    Copy the full SHA
    2aa4cf3 View commit details

  7. 2.33.2

    @filfreire
    filfreire committed Jan 9, 2025
    Copy the full SHA
    c7fb171 View commit details

  8. fix: nan-patch edit for insomnia repo (#79)

    @filfreire
    filfreire authored Jan 9, 2025
    Copy the full SHA
    8ed95c7 View commit details

  9. 2.33.3

    @filfreire
    filfreire committed Jan 9, 2025
    Copy the full SHA
    9cf955f View commit details

Commits on Jan 10, 2025

  1. revert: enable-legacy and weak-ciphers (#80)

    @filfreire
    filfreire authored Jan 10, 2025
    Copy the full SHA
    74a36a4 View commit details

  2. 2.33.4

    @filfreire
    filfreire committed Jan 10, 2025
    Copy the full SHA
    b519400 View commit details

Commits on Jan 23, 2025

  1. Feature/ins-4917-set-up-linux-arm-build-to-support-flatpak (#82) 

    * add target arch flag

* fix cache

* fix target_arch

* fix electron jobs

* skip failing exception tests

* add arm to publish action

* remove test skip and change url on easy.spec.ts

* revert concurrency group setting ref to head_ref

* Update test/curl/easy.spec.ts

---------

Co-authored-by: Filipe Freire <livrofubia@gmail.com>
    @jackkav @filfreire
    jackkav and filfreire authored Jan 23, 2025
    Copy the full SHA
    d5035fa View commit details

  2. 2.33.5

    @filfreire
    filfreire committed Jan 23, 2025
    Copy the full SHA
    ee978f1 View commit details

  3. fix: missing var calling build.sh build-and-release (#84)

    @filfreire
    filfreire authored Jan 23, 2025
    Copy the full SHA
    e764eb5 View commit details

  4. fix: re-enable build-lint-test pull_request dispatch

    @filfreire
    filfreire committed Jan 23, 2025
    Copy the full SHA
    94d30ca View commit details

  5. 2.33.6

    @filfreire
    filfreire committed Jan 23, 2025
    Copy the full SHA
    3efbd14 View commit details

  6. fix: use process.arch to determine default target arch (#85) 

    * fix: use process.arch to determine default target arch

* rm target_arch from build-and-release

---------

Co-authored-by: Filipe Freire <livrofubia@gmail.com>
    @hexchain @filfreire
    hexchain and filfreire authored Jan 23, 2025
    Copy the full SHA
    e1caf5f View commit details

  7. 2.33.7

    @filfreire
    filfreire committed Jan 23, 2025
    Copy the full SHA
    03c1ea8 View commit details
80 changes: 45 additions & 35 deletions .github/workflows/build-and-release.yaml
View file
Original file line number Diff line number Diff line change
@@ -22,10 +22,10 @@ jobs:
permissions:
packages: write
contents: write # publish sbom to GH releases/tag assets
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
path: ${{ github.repository }}

@@ -41,19 +41,21 @@ jobs:
upload-sbom-release-assets: true

build-and-release-nodejs:
permissions: write-all
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os:
- macos-13-xlarge
- ubuntu-22.04
- ubuntu-22.04-arm
libcurl-release:
- 7.79.1
- 7.86.0
node-libcurl-cpp-std:
- c++17
- c++20
node:
- 20.16.0
- 20.18.0

env:
LIBCURL_RELEASE: ${{ matrix.libcurl-release }}
@@ -62,128 +64,135 @@ jobs:
steps:
- if: runner.os == 'macOS'
name: Install Needed packages on macOS
run: brew install coreutils wget automake libtool cmake gnu-sed m4 autoconf@2.69 groff
run: brew install coreutils wget automake libtool cmake gnu-sed m4 autoconf groff
- if: runner.os == 'Linux'
name: Install Needed packages on Linux
run: sudo apt-get install -y cmake
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
cache: 'npm'
cache-dependency-path: package-lock.json
- name: Restore libcurl deps cache
uses: actions/cache@v3
uses: actions/cache@v4
id: libcurl-deps-cache
with:
path: |
~/.node-gyp
~/deps
key: v4-${{ runner.os }}-libcurl-deps-cache-node-${{ matrix.node }}-fork
key: v4-${{ matrix.os }}-libcurl-deps-cache-node-${{ matrix.node }}-fork
restore-keys: |
v4-${{ runner.os }}-libcurl-deps-cache-node-${{ matrix.node }}-fork
v4-${{ matrix.os }}-libcurl-deps-cache-node-${{ matrix.node }}-fork
- name: 'Set GIT_TAG'
if: startsWith(github.ref, 'refs/tags')
run: echo "GIT_TAG=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
- name: 'Publish Binary'
run: |
pip install packaging
GIT_COMMIT=${{ github.sha }} GIT_TAG=$GIT_TAG RUNNER_OS=${{ runner.os }} ./scripts/ci/build.sh
GIT_COMMIT=${{ github.sha }} \
GIT_TAG=$GIT_TAG \
RUNNER_OS=${{ matrix.os }} \
./scripts/ci/build.sh
- name: Upload artifacts
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: build-logs-${{ matrix.os }}-${{ matrix.libcurl-release }}-${{ matrix.node }}
path: ./logs/
retention-days: 5

build-and-release-electron:
permissions: write-all
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os:
- macos-13-xlarge
- ubuntu-22.04
- ubuntu-22.04-arm
libcurl-release:
- 7.79.1
- 7.86.0
node:
- 20.16.0
- 20.18.0
electron-version:
- 31.4.0
- 33.3.0
env:
LIBCURL_RELEASE: ${{ matrix.libcurl-release }}
LATEST_LIBCURL_RELEASE: ${{ matrix.libcurl-release }}
ELECTRON_VERSION: ${{ matrix.electron-version }}
NODE_LIBCURL_CPP_STD: c++17
NODE_LIBCURL_CPP_STD: c++20
steps:
- if: runner.os == 'macOS'
name: Install Needed packages
run: brew install coreutils wget automake libtool cmake gnu-sed m4 autoconf@2.69 groff
run: brew install coreutils wget automake libtool cmake gnu-sed m4 autoconf groff
- if: runner.os == 'Linux'
name: Install Needed packages on Linux
run: sudo apt-get install -y cmake
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup Node.js ${{ matrix.node }}
uses: actions/setup-node@v4
with:
node-version-file: '.nvmrc'
cache: 'npm'
cache-dependency-path: package-lock.json
- name: Restore Electron Cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/Library/Caches/electron
key: v1-${{ runner.os }}-electron-cache-${{ matrix.electron-version }}
key: v1-${{ matrix.os }}-electron-cache-${{ matrix.electron-version }}
restore-keys: |
v1-${{ runner.os }}-electron-cache-${{ matrix.electron-version }}
v1-${{ runner.os }}-electron-cache-
v1-${{ matrix.os }}-electron-cache-${{ matrix.electron-version }}
v1-${{ matrix.os }}-electron-cache-
- name: Restore libcurl deps cache
uses: actions/cache@v3
uses: actions/cache@v4
id: libcurl-deps-cache
with:
path: |
~/.node-gyp
~/deps
key: v4-${{ runner.os }}-libcurl-deps-cache-electron-${{ matrix.electron-version }}-fork
key: v4-${{ matrix.os }}-libcurl-deps-cache-electron-${{ matrix.electron-version }}-fork
restore-keys: |
v4-${{ runner.os }}-libcurl-deps-cache-electron-${{ matrix.electron-version }}-fork
v4-${{ matrix.os }}-libcurl-deps-cache-electron-${{ matrix.electron-version }}-fork
- name: 'Set GIT_TAG'
if: startsWith(github.ref, 'refs/tags')
run: echo "GIT_TAG=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
- name: 'Publish Binary'
run: |
pip install packaging
GIT_COMMIT=${{ github.sha }} GIT_TAG=$GIT_TAG ./scripts/ci/build.sh
# Perform SCA analysis for the code repository
GIT_COMMIT=${{ github.sha }} \
GIT_TAG=$GIT_TAG \
./scripts/ci/build.sh
- name: Upload artifacts
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: build-logs-${{ matrix.os }}-${{ matrix.libcurl-release }}-${{ matrix.electron-version }}
path: ./logs/
retention-days: 5

build-and-release-nodejs-windows:
permissions: write-all
runs-on: windows-latest
strategy:
fail-fast: false
matrix:
node:
- 20.16.0
- 20.18.0
env:
npm_config_msvs_version: 2022
npm_config_build_from_source: true
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
submodules: recursive
- name: Setup Node.js ${{ matrix.node }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
- name: Install dependencies
@@ -211,14 +220,15 @@ jobs:
node scripts\module-packaging.js --publish $(npm run -s pregyp reveal staged_tarball --silent)
build-and-release-electron-windows:
permissions: write-all
runs-on: windows-latest
strategy:
fail-fast: false
matrix:
node:
- 20.16.0
- 20.18.0
electron-version:
- 31.4.0
- 33.3.0
env:
ELECTRON_VERSION: ${{ matrix.electron-version }}
npm_config_msvs_version: 2022
@@ -228,11 +238,11 @@ jobs:
npm_config_target: ${{ matrix.electron-version }}
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
submodules: recursive
- name: Setup Node.js ${{ matrix.node }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
- name: Install dependencies
Loading