Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Biolink category assignment to nodes here (rather than in PHENIO) #157

Closed
caufieldjh opened this issue Nov 21, 2024 · 1 comment · Fixed by #165
Closed

Do Biolink category assignment to nodes here (rather than in PHENIO) #157

caufieldjh opened this issue Nov 21, 2024 · 1 comment · Fixed by #165

Comments

@caufieldjh
Copy link
Contributor

Adding Biolink categories in PHENIO works: it derives category names from the Biolink schema and applies them to children in PHENIO.
Most of this relies on a sparql query: https://github.com/monarch-initiative/phenio/blob/main/src/sparql/bl-categories.ru

The original justification for this was to apply categories as upstream as possible, promoting reuse of an ontology with meaningful category assignments, even when used somewhere other than a KG.

This overall process has some disadvantages:

We can, instead, add categories as part of the KG transform.

@caufieldjh
Copy link
Contributor Author

Note that the current KG transform adds many, but not all Biolink categories:

$ cut -f2 data/transformed/phenio/phenio_node_sources_nodes.tsv | sort | uniq -c | sort
      1 category
    117 biolink:SequenceVariant
   1101 biolink:Protein
   1775 biolink:Cell
   1854 biolink:OrganismTaxon
   4498 biolink:CellularComponent
   5616 biolink:ChemicalEntity
  12576 biolink:MolecularActivity
  15878 biolink:AnatomicalEntity
  17885 biolink:PhenotypicFeature
  27869 biolink:Disease
  30655 biolink:BiologicalProcess
 180234 biolink:NamedThing

@caufieldjh caufieldjh linked a pull request Dec 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant