Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to CDNJS #18

Open
ttodua opened this issue Jan 10, 2019 · 4 comments
Open

Add to CDNJS #18

ttodua opened this issue Jan 10, 2019 · 4 comments
Assignees

Comments

@ttodua
Copy link

ttodua commented Jan 10, 2019

Hi Author. Nice work.
Please add your vote to host your project to CDNjs (your repository has enough stars to pass it), so we could use CDN-ed files, instead of downloading projectfile on your site.
I've opened the request here - cdnjs/cdnjs#13205

thanks

btw, also, please change urls in examples to this, instead of manually downloading files:

<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/jquery/1.11.3/jquery.min.js"></script>
<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/FileSaver.js/1.3.8/FileSaver.min.js"></script>
<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/jszip/3.1.5/jszip.min.js"></script>
@KinoLien KinoLien self-assigned this Jan 23, 2019
@KinoLien
Copy link
Owner

Thank you :-)

I will survey how to add to CDNjs and prepare for that, and also fix #19 in one week.

@KinoLien KinoLien added this to the 1.0.0 release milestone Jan 23, 2019
@KinoLien
Copy link
Owner

According to section A.b on this, it says:
For the new library request issue, please make sure it's not a personal project, we have a basic requirement for the popularity, like 200 stars on GitHub or 800 downloads/month on npm registry.

GitZip has not met the conditions, so I can't do it, at least for now.

@KinoLien KinoLien removed this from the 1.0.0 release milestone Jan 28, 2019
@ttodua
Copy link
Author

ttodua commented Jan 28, 2019

Ok, but I will anyway monitor the topic link i've mentioned in question, as I hope 190 stars is close to 200 starts and some chances are, if they respond to my topic opened there.

btw, in the meantime, i will use JSDelivr:
https://cdn.jsdelivr.net/gh/KinoLien/gitzip/js/jszip.min.js

@NicoWeio
Copy link
Contributor

200 stars on GitHub are definitely surpassed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants