[BUG] Open project modal #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ortichon
added this to the 01. Create a kickass **code editor** for remote programming milestone
|
very nice :-) welcome back 👍 |
thatkookooguy
approved these changes
Dec 29, 2016
|
@thatkookooguy I never know if I should merge it myself after you aprove it :) |
|
merged it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
More info
bindToControllerpass it's attributes to the controller only after the controller initiated.so we got
undefinedfor every variable we passed.using
$onInitlifecycle hook to extend theoptionvariable with theuserOptionsvariable solved the problem (the tree default mode is file and the projectFolder modal need folder mode) as well as the color theme problem.Before you submit a PR, make sure you did the following things: