[FEATURE] Support mobile devices #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -291,4 +349,4 @@ md-input-container { | |||
| } | |||
| // scss-lint:enable IdSelector | |||
| // scss-lint:enable NestingDepth | |||
| // scss-lint:enable SelectorDepth | |||
| // scss-lint:enable SelectorDepth | |||
There was a problem hiding this comment.
Files should end with a trailing newline
|
|
||
| @include phone { | ||
| bottom: 0; | ||
| left: 0 !important; |
| position: absolute; | ||
| right: 0; | ||
| top: 0; | ||
| width: 100% !important; |
Since the sidebar and the main-view doesn't share space on mobile, the following things need to happen: - When selecting a project, the sidebar should open - When selecting a file in the sidebar, the sidebar should close This way, you see the right view when you need. You can still open and close the sidebar yourself using the hamburger and close button
make menu bar smaller on mobile
| @include phone { | ||
| .main-area { | ||
| height: calc(100vh - 52px - 30px) !important; | ||
| top: 52px !important; |
|
|
||
| @include phone { | ||
| .main-area { | ||
| height: calc(100vh - 52px - 30px) !important; |
| } | ||
|
|
||
| .mobile-sidebar { | ||
| display: none; |
There was a problem hiding this comment.
Properties should be ordered color, display
|
Thought about making this one big media query instead of lots of little ones, but after reading this, performance problems don't worry me as much |
…bile # Conflicts: # public/app/views/index.html
+ fixes like: - no more duplication of sidebar
| } | ||
|
|
||
| .menu-button { | ||
| display: none; |
There was a problem hiding this comment.
Properties should be ordered color, display, fill
thatkookooguy
changed the title
thatkookooguy
added this to the 01. Create a kickass **code editor** for remote programming milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
make kibibit support(-ish) mobile devices. [resolves SUPPORT-ISH FOR MOBILE #180]
More info
This turned out to look pretty good! I'm proud :-)