[FEATURE] Add some pizzazz to our menu bar component #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ some case conversation buttons
| var selection = vm.settings.currentEditor.selection.getRange(); | ||
| var titleCased = selectionText.replace( | ||
| /[_-\s]([a-zA-Z])|([a-z])([A-Z])/g, | ||
| function (g, singleLetter, firstLetter, secondLetter) { |
There was a problem hiding this comment.
Illegal space before opening round brace
thatkookooguy
added this to the 01. Create a kickass **code editor** for remote programming milestone
thatkookooguy
changed the title
thatkookooguy
changed the title
| * This message is: | ||
| * | ||
| * "Automatically scrolling cursor into view after selection change | ||
| * this will be disabled in the next version |
good boy!
| var editor = vm.settings.currentEditor; | ||
| var selectionText = editor.getSelectedText(); | ||
| var selection = vm.settings.currentEditor.selection.getRange(); | ||
| selectionText = selectionText |
|
@ortichon I'm merging this this evening (skipping your CR) since a long time have passed (12 days) and I want to continue to other things Talk to me if you planned getting to this soon and I'll wait some more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
add some more built-in
ace.jsintegrations to themenuBarcomponent [resolves add more ace.js integrations #169]Made new
menuBarmenu calledSelection[resolves add selection menu to the menuBar component #168]Allow
ace.jsto scroll the last line to the top (like most modern code editors) [resolves Add scroll last line to top behaviour for the editor #170]Cleaned up more buttons in the menu bar