combine all editors to a single mega-editor #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatkookooguy
added this to the 01. Create a kickass **code editor** for remote programming milestone
| @@ -9,6 +9,22 @@ kb-code-editor { | |||
| .editor { | |||
| height: 100%; | |||
| width: 100%; | |||
| &.half-editor { | |||
There was a problem hiding this comment.
Rule declaration should be preceded by an empty line
| }); | ||
| } | ||
| }; | ||
|
|
||
| vm.shouldShowCompiledView = function() { | ||
| vm.showCompiledView = editorSettings.syntaxMode === 'json' || editorSettings.syntaxMode === 'markdown'; |
There was a problem hiding this comment.
Line must be at most 80 characters
| }); | ||
| } | ||
| }; | ||
| }); |
thatkookooguy
assigned ortichon and thatkookooguy and unassigned thatkookooguy and ortichon
|
When we have empty object viewed in JSON editor, the text is dark on dark, which makes it hard to read. |
|
LGTM 💯 |
| top: 0; | ||
|
|
||
| .json-formatter-row { | ||
| color: white; |
There was a problem hiding this comment.
Color white should be written in hexadecimal form as #ffffff
Color literals like white should only be used in variable declarations; they should be referred to via variable everywhere else.
|
LGTM |
neilkalman-redkix
pushed a commit
that referenced
this pull request
Jul 4, 2016
combine all editors to a single mega-editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
combine all editors into a MEGA-EDITOR [resolves combine editors #133]
make
es6open asjavascript[resolves Add temporary es6 support #135 ]More info
BASE: https://kibibit-demo.herokuapp.com/
MODIFIED: https://kibibit-demo-pr-134.herokuapp.com/
Scenario to check:
try and change existing file types to
jsonormarkdown, try opening a file in one of those formats, and try changing the style of the default (no file) documentBefore you submit a PR, make sure you did the following things: