Add file type on server side #132
Conversation
add mime type checking on server side when serving files. This later might come as part of the tree, and than passed on with the file object. but for testing purposes, it's cool as it is atm
thatkookooguy
added this to the 01. Create a kickass **code editor** for remote programming milestone
| } | ||
| function getModeFromMimeType(file) { | ||
| var getModeRegex = /\/(x-)?(.*)$/; | ||
| return file && file.mimeType ? file.mimeType.match(getModeRegex)[2] : 'text'; |
There was a problem hiding this comment.
Line must be at most 80 characters
|
Fixed a closing tag issue in the master branch. noticed it since kibibit changed the syntax of |
| } | ||
| ]) | ||
|
|
||
| .directive('kbChangeAceScroll', function() { |
There was a problem hiding this comment.
@thatkookooguy
What about this directive?
There was a problem hiding this comment.
It wasn't attached anywhere. It was a leftover from an experiment I did in a previous PR
|
@thatkookooguy Edit: |
|
@thatkookooguy |
|
@ortichon I made it invalid for now until you actually see a compiled SVG view. Because you can't actually see what you're doing :-) |
|
LGTM |
Add file type on server side
Change Summary
Passing to client the mime-type of each file [resolves integrate mime\type module to check for file types #80]
fixed some issues with settingsService + some nits :-) [resolves settingsService prints out the wrong assertion error on NO MATCH FOUND #131]
did you link this PR to an issue?
did you lint your changes to both javascript and scss?
"I'm pretty sure I'll be able to read and understand this PR, even if I wasn't the author." - _said the PR author_