Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme ace's search for kibibit + create _codeEditor.scss #127

Merged
merged 5 commits into from
May 15, 2016

Conversation

thatkookooguy
Copy link
Member

@thatkookooguy thatkookooguy commented May 14, 2016

BASE
DEMO

_REPRODUCE_:

  1. open a project on kibibit and open a random file
  2. do a cmd+F (OS X) or ctrl+F (Windows) for search, or double that for search and replace
  3. look for a common word.

differences:

  • search looks different
  • highlighted word looks different

Change Summary

  • Theme ace's search to match Kibibit's style 😄 [resolves Restyle ace's search to look like kibibit #126]

    Initially I made the search appear at the bottom with width: 100%, it hides the scroll-bars, so this is my solution for now :-)
    We could later create our own UI that will only call ace's search functions.
    Also, as part of this mission, I re-styled ace's highlight colors since it wasn't very visible.

  • move all the code editor styles + new ones to _codeEditor.scss

More info

currently, 3 temp icons where made (the original ace's icons, painted in our main color). later, we'll need to make this more robust (svg mask + background color?)
further changes will be needed at some point ofc

Before you submit a PR, make sure you did the following things:

  • did you link this PR to an issue?
  • did you lint your changes to both javascript and scss?
  • "I'm pretty sure I'll be able to read and understand this PR, even if I wasn't the author." - _said the PR author_

This change is Reviewable

further changes will be needed at some point ofc
@thatkookooguy thatkookooguy requested a deployment to kibibit-demo-pr-127 May 14, 2016 21:55 Pending
}
}
// scss-lint:enable all
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files should end with a trailing newline

@thatkookooguy thatkookooguy requested a deployment to kibibit-demo-pr-127 May 14, 2016 21:57 Pending
@thatkookooguy thatkookooguy requested a deployment to kibibit-demo-pr-127 May 14, 2016 21:58 Pending
@thatkookooguy
Copy link
Member Author

Hi @ortichon , this shouldn't effect your changes, since this is only css changes.
Since this is only css and shouldn't break anything, I might merge this by tomorrow noon if you won't have time to go over it.

@thatkookooguy thatkookooguy temporarily deployed to kibibit-demo-pr-127 May 14, 2016 22:06 Inactive
@thatkookooguy thatkookooguy temporarily deployed to kibibit-demo-pr-127 May 14, 2016 22:16 Inactive
@ortichon
Copy link
Member

ortichon commented May 15, 2016

LGTM

Approved with PullApprove

@ortichon ortichon merged commit a35394d into master May 15, 2016
@ortichon ortichon deleted the refactor-editor-style branch May 15, 2016 09:00
neilkalman-redkix pushed a commit that referenced this pull request Jul 4, 2016
theme ace's search for kibibit + create _codeEditor.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restyle ace's search to look like kibibit
3 participants