Code editor settings #129
Code editor settings #129
Conversation
Conflicts: public/assets/sass/style.scss
|
@thatkookooguy Oh darn, I forgot about the highlight as well. reject my LGTM |
|
@thatkookooguy cancel my LGTM |
|
|
||
| &:focus { | ||
| color: $primary; | ||
| background: rgb(238,238,238); |
There was a problem hiding this comment.
Commas in function arguments should be followed by a single space
Color literals like rgb(238, 238, 238) should only be used in variable declarations; they should be referred to via variable everywhere else.
Also, styled the background of the input menu
| // this is important because we want to apply the style | ||
| // to the selected item (which is excluded in the previous styling rule) | ||
| &:focus:not([disabled]) { | ||
| color: $primary; |
There was a problem hiding this comment.
Properties should be ordered background, color
|
Added a hound exception for now for number of attribute inside a single class. I need to disable all those checks globally already, it's just the last time I tried to set my own rules for hound, it didn't work :-) |
|
now I'm waiting for a code review from you on this commit ( @ortichon ) if you think this is good, I'll give you my LGTM after that |
|
cancel my LGTM |
|
@thatkookooguy LGTM |
|
@thatkookooguy Test - telegram comment |
|
@thatkookooguy another test |
|
LGTM
|
Code editor settings
Change Summary
Integrate
ace.jscode editor settings in Kibibit's settings [resolves integrate ace.js settings with kibibit #118]More info
settings added:
Before you submit a PR, make sure you did the following things:
This change is