make undo and redo buttons work #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, the undo and redo buttons should work with the ace editor
thatkookooguy
added this to the 01. Create a kickass **code editor** for remote programming milestone
| }; | ||
|
|
||
| vm.hasRedo = function() { | ||
| if (vm.settings.currentUndoManager && vm.settings.currentUndoManager.hasRedo) { |
There was a problem hiding this comment.
Line must be at most 80 characters
+ make cut and copy work, even though we might remove those buttons later completely, since `paste` can't work on web (Solution?)
| vm.cutSelection = function(e) { | ||
| vm.settings.currentEditor.session.replace(vm.settings.currentEditor.selection.getRange(), ''); | ||
| vm.settings.currentEditor.focus(); | ||
| } |
good boy, hound!
| } | ||
| }; | ||
|
|
||
| vm.cutSelection = function(e) { |
There was a problem hiding this comment.
Expected indentation of 2 characters
| "velocity": "~1.2.3" | ||
| "velocity": "~1.2.3", | ||
| "ngclipboard": "~1.1.1", | ||
| "ng-device-detector": "~3.0.1" |
There was a problem hiding this comment.
I left this here even though I didn't use it, since we'll need this for MixPanel
|
what about the [still need to open a bug for this!] comments? ;-) |
|
@ortichon , that's because it was added later since you took your time with the code-review... 😝 This CL originally didn't include those two changes but I finished them before you started the code review |
|
LGTM |
neilkalman-redkix
pushed a commit
that referenced
this pull request
Jul 4, 2016
make undo and redo buttons work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Connect editor's
undoandredowith the menu-bar buttons [ resolves Connect editor's undo and redo with the menu-bar buttons #108 ]Connect editor's
cutandcopyto the menu bar buttons [ resolves Make the copy cut paste buttons functional #111 ]Implemented a loading splash screen with
kibibit's logo :-) [ resolves Add splash logo on load #110 ]More info
Later, this will be inside the
stateServiceobject, which will save the current state (and won't be saved to the server like thesettingsServiceshould)BASE DEMO: https://kibibit-demo.herokuapp.com/
MODIFIED DEMO: https://kibibit-demo-pr-109.herokuapp.com/
This change is