Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_api min_max_image_buffer_size #2245

Open
rjodinchr opened this issue Jan 24, 2025 · 0 comments
Open

test_api min_max_image_buffer_size #2245

rjodinchr opened this issue Jan 24, 2025 · 0 comments

Comments

@rjodinchr
Copy link
Contributor

In that test we are comparing CL_DEVICE_IMAGE_MAX_BUFFER_SIZE with CL_DEVICE_MAX_MEM_ALLOC_SIZE/MAX_DEVICE_MEMORY_SIZE_DIVISOR.

#define MAX_DEVICE_MEMORY_SIZE_DIVISOR (2)

/* We need to use a portion of available alloc size,
 * divide it to leave some memory for the platform. */

thus it means that if a device reports CL_DEVICE_IMAGE_MAX_BUFFER_SIZE = CL_DEVICE_MAX_MEM_ALLOC_SIZE/2 + 1, the test is failing, while it feels that it should still be passing.

leaving half of the space of the platform is quite a lot, and it feels quite arbitrary.

Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant