Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Alias should allow symbol imports #22

Open
benjaminjkraft opened this issue Mar 23, 2018 · 0 comments
Open

Alias should allow symbol imports #22

benjaminjkraft opened this issue Mar 23, 2018 · 0 comments

Comments

@benjaminjkraft
Copy link
Contributor

benjaminjkraft commented Mar 23, 2018 •
edited
Loading

Currently, we only ever generate imports of modules, even if your old import was importing a symbol from a module and you're using auto-alias. We should also have a flag like FROM that says to use symbol imports whereever possible; then FROM would say use module from-imports whereever possible.

(None of this affects KA much, since we generally disallow symbol imports, but the rest of the world uses them surprisingly much!)
@benjaminjkraft benjaminjkraft changed the title Alias should alow symbol imports Alias should allow symbol imports Mar 23, 2018
benjaminjkraft added a commit that referenced this issue Mar 24, 2018
@benjaminjkraft
Add a test for symbol imports
a962fed 
We don't use these at KA, but the rest of the world does.  This was
mostly to convince myself we at least generate legal code.  I also
included a skipped test for #22, which I wrote first.

Test plan: `make check`

Auditors: csilvers
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjaminjkraft