Use map contains checks for gui textures #432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indexing against a map for a key that doesn't exist will insert a default object constructed to that map.
The gui texture map was being indexed on lookup for texture IDs, and the
texture 0
is generally the main renderer framebuffer texture. This can lead to that texture being displayed into ImGui unexpectedly.Example of non-existent key returning framebuffer:

This adds a proper
contains()
check before indexing against the map to avoid inserting a default value into the map, and will returnnullptr
or size 0 in the following functions.