New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always first perform least expensive validations #234

Open

Glitchy-Tozier opened this issue Sep 10, 2022 · 1 comment

Labels

Glitchy-Tozier commented Sep 10, 2022

Basically, first perform length-checks (especially for arrays) and only then perform all other checks. Perform custom checks last.

This is to aid as an additional buffer against primitive DOS attacks.

Keats added the enhancement label

jmjoy commented Jan 18, 2024

Maybe throw a compile-time warning when length-checks aren't defined firstly in #[validate] is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment