Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 11 minimal application code #15

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

oleschwen
Copy link
Collaborator

This application code serves two purposes

  • testing a training that runs quickly without depending on any data to be present
  • example for writing own application code using pytorch.

@oleschwen oleschwen linked an issue Oct 16, 2024 that may be closed by this pull request
@oleschwen oleschwen self-assigned this Oct 16, 2024
Copy link
Contributor

@Ultimate-Storm Ultimate-Storm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work, can be merged after adding a ReadME

@@ -0,0 +1,129 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we change the name of the script to [config_swarm_client.conf] ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll change it.
As I copied this from a different job folder, we should also adapt it there.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable. The expected file names are hard-coded in NVFlare.

from datetime import datetime


def load_environment_variables():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete this block

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll change it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it is needed. But there is no reason to have a separate file env_config.py; the code can go directly in minimal_training.py.

@@ -0,0 +1,9 @@
name = "minimal_training"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a more illustrative name like minimal_training_3dcnn, or we can specify it within the ReadME

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's 2D :-) but yes, the name could be more specific. minimal_training_pytorch_cnn?

@oleschwen
Copy link
Collaborator Author

I've created a README.md in the application code folder.
This is getting a bit redundant with other application code, I'll create a follow-up issue to refactor documentation, also taking into account #14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement minimal application code for testing
2 participants