-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev 11 minimal application code #15
base: main
Are you sure you want to change the base?
Conversation
use synthetic data and removed unused code (but still a ResNet)
…le what the difference is
…oductive jobs, test jobs and example jobs
resolved conflict in _runTestsInsideDocker.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work, can be merged after adding a ReadME
@@ -0,0 +1,129 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we change the name of the script to [config_swarm_client.conf] ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll change it.
As I copied this from a different job folder, we should also adapt it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable. The expected file names are hard-coded in NVFlare.
from datetime import datetime | ||
|
||
|
||
def load_environment_variables(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can delete this block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it is needed. But there is no reason to have a separate file env_config.py
; the code can go directly in minimal_training.py
.
@@ -0,0 +1,9 @@ | |||
name = "minimal_training" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a more illustrative name like minimal_training_3dcnn, or we can specify it within the ReadME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's 2D :-) but yes, the name could be more specific. minimal_training_pytorch_cnn?
I've created a README.md in the application code folder. |
This application code serves two purposes