-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New advertise detecting system #82
Comments
I don't really unstand your message.
as asked a couple of times - what is the value of adding this? We would already be checking (with a regex) both the one you want to exclude and include. If there is a proper fault in our ip/domain checker please comment the cases which is not found. |
I suggest this Because now, it has lots of false positives, for example, if i use points in a text, your plugin detect it has address spam |
There is other stuff I want to add and adding a system to verify stuff is using a remote connection isn't on the list. if you want ot see such a think you should make a PR for it. as said i need example messassages to fix it, which specifc cases would you like it to contain? |
Can you explain this more easy? |
without examples i can't fix it. |
Es: |
Without a log and a config I can't see your settings :) neither of the wed filters find it (advanced and simple) PLEASE put your config and your log at a gist. |
Config: https://pastebin.com/bnp1VWci |
You are using the advanced one and only one of the messages (hhahahahahah......no) are catched in the filter you are currently using. I am making some changes which should fix the problem on those. |
All log are false positives (bot only hahahaha) |
As said examples else I have no way to fix it.. |
All logs, see the logs link |
Without the proper messages I have no way to fix it :). Your messages doesn't contain the the reason why it is blocked, which would be in the server log |
Your plug-in detect the text in my log because "..." seems to be an advertise spam |
not on any of the patterns - you are using the advanced one? your setting is saying you do. the filter does not track ... as spam because of the filters, but I have now updated the message in the log we make to have which filter is the reason for it, so in tjhe next version it is better. I have also updated the plugin to not check . in domains |
So i must download it now and test? |
you must wait for a new pre release |
Ok, i Will wait :) |
As it will be in the next release I will add it to they once it has been tested properly |
Ok, let me know |
Make a better system of detecting IPs (actual is very bad). So this new detect system will check EVERY words wrote in a text of a player. For Example: "Hi, join in Mc.servername.it!", your plugin will search if this ip works, and if work, the plugin will stop the text from its send. If the text is: "Hi, Join in Mc.serverthatnotexist.it" the plugin will see that this ip is not real and it doesn't stop the send of the text.
What you don't understand?
The text was updated successfully, but these errors were encountered: