-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document 'meson subprojects update --reset' #28
Comments
My understanding is that writing For ref: https://mesonbuild.com/External-Project-module.html#using-wrap-file I would have assumed meson patches file back after updating its git deps. If not, I think it is an upstream issue. |
I believe you are correct. I just looked through the structure of the wrapdb project and it matches what you state. I opened an issue upstream |
See mesonbuild/meson#13970 (comment) for the fix. I'll re-title this issue to suggest documenting it here. Note I didn't read through the meson docs or the dupe issue to see if there are cases when the reset arg should not be appended. |
Thanks for figuring this out. To be honest I feels like meson is doing the wrong thing in this case. But the fact updating a git wrap does not apply the patch automatically after the first time makes no sense in my head :/. In any case, I will add a note in the build docs. |
Confusing to me as well. If the patch is always wiped when updating, that just basically means you always have to use --reset, unless you don't have any subprojects that uses patches. |
tree-sitter wasn't shown in the output but is on L79 of meson.build.
Removing subprojects/tree-sitter and re-running
bun run meson-setup.clang-release
fixed the issue.Looking briefly at the tree-sitter wrap, the problem may be with using the subproject dir as the patch directory. Paradox?
The text was updated successfully, but these errors were encountered: