Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset calibration broken in v1.7.0-b2 #1553

Closed
lennremy opened this issue Jan 8, 2025 · 3 comments · Fixed by #1555
Closed

Offset calibration broken in v1.7.0-b2 #1553

lennremy opened this issue Jan 8, 2025 · 3 comments · Fixed by #1555
Assignees
Labels
bug Something isn't working

Comments

@lennremy
Copy link

lennremy commented Jan 8, 2025

Since version 1.7.0-b2, the calibration of Tado thermostats no longer works. The offset value is always set to 0°C. Although the temperature difference between thermostat and thermometer is detected and calculated in the logs, it is not properly transmitted to Tado.

Does work properly after downgrading to 1.7.0-b1.

2025-01-08 09:47:08.349 DEBUG (MainThread) [custom_components.better_thermostat.events.trv] better_thermostat BT Schlafzimmer: TRV climate.schlafzimmer sends new internal temperature from 20.5 to 20.6 2025-01-08 09:47:08.350 DEBUG (MainThread) [custom_components.better_thermostat.events.trv] better_thermostat BT Schlafzimmer: trigger_trv_change test / _old_heating_setpoint: 21.0 - _new_heating_setpoint: 21.0 - _last_temperature: 21.0 2025-01-08 09:47:08.351 DEBUG (MainThread) [custom_components.better_thermostat.model_fixes.model_quirks] better_thermostat BT Schlafzimmer: climate.schlafzimmer - calibration offset model fix: -2.400000000000002 to -2.4 2025-01-08 09:47:08.351 DEBUG (MainThread) [custom_components.better_thermostat.calibration] better_thermostat BT Schlafzimmer: climate.schlafzimmer - new local calibration: 0.0 | external_temp: 18.2, trv_temp: 20.6, calibration: 0.0 2025-01-08 09:47:08.509 DEBUG (MainThread) [custom_components.better_thermostat.events.trv] better_thermostat BT Wohnzimmer: TRV climate.wohnzimmer_2 sends new internal temperature from 22.5 to 22.4 2025-01-08 09:47:08.510 DEBUG (MainThread) [custom_components.better_thermostat.events.trv] better_thermostat BT Wohnzimmer: trigger_trv_change test / _old_heating_setpoint: 20.0 - _new_heating_setpoint: 20.0 - _last_temperature: 20.0

@lennremy lennremy added the new bug incoming bug issue label Jan 8, 2025
folfy added a commit to folfy/better_thermostat that referenced this issue Jan 8, 2025
@folfy
Copy link
Collaborator

folfy commented Jan 8, 2025

Please follow the bug report template, we need at least the debug data to understand your issue:
diagnostic data
IMPORTANT:
Download and paste the diagnostic data from your Better Thermostat Entity(s) below.
https://www.home-assistant.io/docs/configuration/troubleshooting/#download-diagnostics

The new, desired values is calculated as: new local calibration: 0.0, so not an issue of "setting" things. Fortunately the value for "tado" is hardcoded, so I can understand the issue without the diagnostic data. Needed to fix rounding in PR #1555, sry.

@lennremy
Copy link
Author

lennremy commented Jan 8, 2025

Sorry for not following the template, I'm new to github and didnt know better.

I did include a snippet from the diagnostic data, but here is the full log I downloaded.
home-assistant_better_thermostat_2025-01-08T08-47-25.647Z.log

Do you need any additional information? I apologize again - I’m not a developer, but I wanted to try to help.

@folfy
Copy link
Collaborator

folfy commented Jan 8, 2025

It's ok, for this issue fortunately everything should be clear, so we just need to test the fix and release a new b3 Version with it

@folfy folfy assigned folfy and unassigned KartoffelToby Jan 9, 2025
@folfy folfy added bug Something isn't working and removed new bug incoming bug issue labels Jan 9, 2025
@folfy folfy changed the title Tado Thermostat calibration not working - offset value always set to 0°C since v1.7.0-b2 Offset calibration broken in v1.7.0-b2 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants