Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting option flow config_entry is deprecated (HA 2025.12) #1530

Open
folfy opened this issue Dec 20, 2024 · 3 comments · May be fixed by #1557
Open

setting option flow config_entry is deprecated (HA 2025.12) #1530

folfy opened this issue Dec 20, 2024 · 3 comments · May be fixed by #1557
Assignees
@KartoffelToby
Labels
bug Something isn't working

Comments

@folfy
Copy link
Collaborator

folfy commented Dec 20, 2024 •
edited
Loading

Description

Deprecation warning from HA for BT:

WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'better_thermostat' sets option flow config_entry explicitly, which is deprecated at custom_components/better_thermostat/config_flow.py, line 393: self.config_entry = config_entry. This will stop working in Home Assistant 2025.12, please create a bug report at https://github.com/KartoffelToby/better_thermostat/issues

Steps to Reproduce

Reconfigure BT instance while debugging enabled.

Versions

HA 2024.12
BT 1.6.1
@folfy folfy added the new bug incoming bug issue label Dec 20, 2024
@SaaX-IRL SaaX-IRL mentioned this issue Dec 27, 2024
Closed
@folfy folfy mentioned this issue Jan 5, 2025
Closed
3 tasks
@folfy
Copy link
Collaborator Author

folfy commented Jan 5, 2025

@KartoffelToby can we pin this issue please?

@KartoffelToby KartoffelToby pinned this issue Jan 6, 2025
folfy added a commit to folfy/better_thermostat that referenced this issue Jan 9, 2025
@folfy
KartoffelToby#1530: fix deprecation warning - config_entry should be …
714d454 
…set in base class
folfy added a commit to folfy/better_thermostat that referenced this issue Jan 9, 2025
@folfy
KartoffelToby#1530: fix deprecation warning - config_entry should be …
67dc55a 
…set in base class
folfy added a commit to folfy/better_thermostat that referenced this issue Jan 9, 2025
@folfy
KartoffelToby#1530: fix deprecation warning - config_entry should be …
ece87d0 
…set in base class
@folfy folfy linked a pull request Jan 9, 2025 that will close this issue
Open
4 tasks
@folfy folfy added bug Something isn't working and removed new bug incoming bug issue labels Jan 9, 2025
folfy added a commit to folfy/better_thermostat that referenced this issue Jan 9, 2025
@folfy
KartoffelToby#1530: fix deprecation warning - config_entry should be …
ad27a85 
…set in base class
folfy added a commit to folfy/better_thermostat that referenced this issue Jan 9, 2025
@folfy
KartoffelToby#1530: fix deprecation warning - config_entry should be …
dcefe63 
…set in base class
@folfy
Copy link
Collaborator Author

folfy commented Jan 9, 2025

Bugfix in PR #1557 is tested - ready for review and merge

@folfy folfy mentioned this issue Jan 13, 2025
Open
@folfy folfy unpinned this issue Jan 13, 2025
@folfy
Copy link
Collaborator Author

folfy commented Jan 14, 2025

Actually this might require us to use HA 2024.12+ or still add it conditionally, based on this commit.

@Tidone Tidone mentioned this issue Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KartoffelToby KartoffelToby

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1530: fix deprecation warning - config_entry set in base class folfy/better_thermostat
2 participants
@folfy @KartoffelToby