Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xref. https://github.com/github/accessibility-audits/issues/8673 #9

Open
Karliz24 opened this issue Jul 4, 2024 · 0 comments
Open

Comments

@Karliz24
Copy link
Owner

Karliz24 commented Jul 4, 2024

xref. https://github.com/github/accessibility-audits/issues/8673

Description

The position: absolute used for this text caused the text to stay at the same position when the user scrolls through the changes list (zooming to 200% while making the window as small as possible is the best way to repro this issue).

This PR switches to a position: relative (and all other positioning changes needed to position it properly). The only side-effect of this change is that now when the button is focused, the text is also outlined (see the screenshot below).

Screenshots

image

Release notes

Notes: [Fixed] Add/Remove Co-authors hint text is positioned correctly when scrolling through the changes list

Publicación original de @sergiou87 en desktop/desktop#18929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant