From 96727f643c664d39223377f18d2538a3275f41c3 Mon Sep 17 00:00:00 2001 From: Stefan <79119093+Stenimated@users.noreply.github.com> Date: Mon, 24 Jun 2024 20:20:24 +0200 Subject: [PATCH 1/3] Add Path2DControlPoint.new to roblox_base.yml (#605) this lint works fine for the majority. besides this bellow, it'll require all 3 args if the second one is present Path2DControlPoint.new(UDim2.new(), UDim2.new()) -- RUNTIME ERROR any way to lint for that --- CHANGELOG.md | 2 ++ selene-lib/default_std/roblox_base.yml | 12 ++++++++++++ 2 files changed, 14 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ad388a10..0e6a62ce 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). ## [Unreleased](https://github.com/Kampfkarren/selene/compare/0.27.1...HEAD) +### Added +- Added `Path2DControlPoint.new` to the Roblox standard library ## [0.27.1](https://github.com/Kampfkarren/selene/releases/tag/0.27.1) - 2024-04-28 ### Fixed diff --git a/selene-lib/default_std/roblox_base.yml b/selene-lib/default_std/roblox_base.yml index 6d99221b..6be6df1b 100644 --- a/selene-lib/default_std/roblox_base.yml +++ b/selene-lib/default_std/roblox_base.yml @@ -349,6 +349,18 @@ globals: OverlapParams.new: args: [] must_use: true + Path2DControlPoint.new: + args: + - required: false + type: + display: UDim2 + - required: false + type: + display: UDim2 + - required: false + type: + display: UDim2 + must_use: true PathWaypoint.new: args: - required: false From 23411d5b4674adf09ec6b8dc79e035a1538237b7 Mon Sep 17 00:00:00 2001 From: LinuxOnTheDesktop <47056543+LinuxOnTheDesktop@users.noreply.github.com> Date: Sat, 29 Jun 2024 00:43:44 +0100 Subject: [PATCH 2/3] Amend installation.md so as to make its instruction about `--no-default-features` harder to misunderstand (#607) Closes #606. --- docs/src/cli/installation.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/cli/installation.md b/docs/src/cli/installation.md index 696021c9..49f8cd38 100644 --- a/docs/src/cli/installation.md +++ b/docs/src/cli/installation.md @@ -16,4 +16,4 @@ cargo install --branch main --git https://github.com/Kampfkarren/selene selene ``` ### Disabling Roblox features -selene is built with Roblox specific lints by default. If you don't want these, type `--no-default-features` after whichever command you choose. +selene is built with Roblox specific lints by default. If you don't want these, then pass `--no-default-features` to the `cargo install` command. From 6e02c2ff8dd9579c1ec165ee11effbecd368f54a Mon Sep 17 00:00:00 2001 From: Jos Dehaes Date: Sat, 29 Jun 2024 01:52:37 +0200 Subject: [PATCH 3/3] add aarch64 build (#599) Hi, In asahi linux (aarch64), selene is not available in neovim because mason can not download an artifact for it (there is no aarch64 linux on github releases). To fix this, I added a cross compilation step to generate and upload an aarch64 linux binary. I tested this in my fork, and it correctly generates aarch64 binaries. Please let me know if you like something changed! Co-authored-by: boyned//Kampfkarren --- .github/workflows/build.yml | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 28ac794b..760b6692 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -78,6 +78,18 @@ jobs: with: name: selene-linux path: ./target/release/selene + - name: Build arm64 (Default features) + uses: actions-rs/cargo@v1 + with: + working-directory: selene + use-cross: true + command: build + args: --locked --release --target aarch64-unknown-linux-gnu + - name: Upload selene arm64 + uses: actions/upload-artifact@v1 + with: + name: selene-linux-aarch64 + path: ./target/aarch64-unknown-linux-gnu/release/selene build_linux_light: runs-on: ubuntu-latest steps: @@ -91,6 +103,18 @@ jobs: with: name: selene-light-linux path: ./target/release/selene + - name: Build arm64 (Lightweight) + uses: actions-rs/cargo@v1 + with: + working-directory: selene + use-cross: true + command: build + args: --locked --release --verbose --no-default-features --target aarch64-unknown-linux-gnu + - name: Upload selene-light arm64 + uses: actions/upload-artifact@v1 + with: + name: selene-light-linux-aarch64 + path: ./target/aarch64-unknown-linux-gnu/release/selene release: runs-on: ubuntu-latest needs: ['build_windows_light', 'build_windows', 'build_mac', 'build_mac_light', 'build_linux', 'build_linux_light']