diff --git a/.github/workflows/type-checking.yml b/.github/workflows/type-checking.yml index a60d2aa..8081ea2 100644 --- a/.github/workflows/type-checking.yml +++ b/.github/workflows/type-checking.yml @@ -24,6 +24,6 @@ jobs: with: python-version: ${{ matrix.python-version }} cache: "pip" - cache-dependency-path: "docs/requirements.txt" - - run: pip install -r "docs/requirements.txt" + cache-dependency-path: "requirements.txt" + - run: pip install -r "requirements.txt" - run: mypy . --python-version=${{ matrix.python-version }} diff --git a/README.md b/README.md index fd8d819..673ea08 100644 --- a/README.md +++ b/README.md @@ -211,7 +211,7 @@ If you want to use this code or contribute, you can either: * Create a fork of the [repository](https://github.com/Kalmat/PyMonCtl), or * [Download the repository](https://github.com/Kalmat/PyMonCtl/archive/refs/heads/master.zip), uncompress, and open it on your IDE of choice (e.g. PyCharm) -Be sure you install all dependencies described on `docs/requirements.txt` by using pip +Be sure you install all dependencies described on `requirements.txt` by using pip python3 -m pip install -r requirements.txt diff --git a/dist/PyMonCtl-0.6-py3-none-any.whl b/dist/PyMonCtl-0.6-py3-none-any.whl index ee9677b..3beab4e 100644 Binary files a/dist/PyMonCtl-0.6-py3-none-any.whl and b/dist/PyMonCtl-0.6-py3-none-any.whl differ diff --git a/src/ewmhlib/_ewmhlib.py b/src/ewmhlib/_ewmhlib.py index 8320e93..0270ab4 100644 --- a/src/ewmhlib/_ewmhlib.py +++ b/src/ewmhlib/_ewmhlib.py @@ -1096,6 +1096,8 @@ def getName(self) -> Optional[str]: # Thanks to cedricscheepers - https://github.com/cedricscheepers for pointing out this issue ret: Optional[Xlib.protocol.request.GetProperty] = self.getProperty(Window.NAME) res: Optional[Union[List[int], List[str]]] = getPropertyValue(ret, display=self.display) + # Some (older) apps do not set _NET_WM_NAME property, but WM_NAME. Using it as fallback + # Thans to ReaperMantis - https://github.com/ReaperMantis for finding a solution! if res: return str(res[0]) ret = self.getProperty(Window.LEGACY_NAME)