Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ophthalmology - Add manual blinking and eye injuries #296

Open
wants to merge 61 commits into
base: dev-Tomcat
Choose a base branch
from
Open

Ophthalmology - Add manual blinking and eye injuries #296

wants to merge 61 commits into from

Conversation

Katalam
Copy link
Contributor

@Katalam Katalam commented Apr 24, 2023

When merged, this pull request will:

  • Create a feature to have the need to blink manually
  • Adds an addon keybind for it
  • Adds an addon option to enable or disable
  • Adds an addon option to adjust the time span you need to blink
  • Adds an addon option to adjust the intensity for the post process effect

@MiszczuZPolski MiszczuZPolski added the kind/feature request Release Notes: **ADDED:** label Apr 24, 2023
@MiszczuZPolski MiszczuZPolski added this to the Ongoing milestone Apr 24, 2023
@Katalam
Copy link
Contributor Author

Katalam commented Apr 24, 2023

The stringtable is pretty fucked atm, some adjustments are needed there

MiszczuZPolski
MiszczuZPolski requested changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@MiszczuZPolski MiszczuZPolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably missed smth, i am not good with PP Effects so i can't really review this without access to Arma.
I think few things would need to be discussed further.

MiszczuZPolski
MiszczuZPolski previously requested changes May 2, 2023
View reviewed changes
@MiszczuZPolski MiszczuZPolski changed the title add: manual blinking Ophthalmology - Add manual blinking and eye injuries May 2, 2023
@mazinskihenry mazinskihenry modified the milestones: Ongoing, 3.1.0 Jan 29, 2025
LinkIsGrim
LinkIsGrim previously requested changes Feb 2, 2025
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is all I've got for now. @MiszczuZPolski asked for my review.

@Alfred-Neuman Alfred-Neuman mentioned this pull request Feb 20, 2025
Draft
@mazinskihenry mazinskihenry dismissed LinkIsGrim’s stale review February 21, 2025 21:24

All points resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiszczuZPolski MiszczuZPolski MiszczuZPolski left review comments

@LinkIsGrim LinkIsGrim LinkIsGrim requested changes

@mazinskihenry mazinskihenry mazinskihenry approved these changes

@AtrixZockt AtrixZockt AtrixZockt left review comments

Assignees
No one assigned
Labels
kind/feature request Release Notes: **ADDED:**
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Katalam @mazinskihenry @AtrixZockt @LinkIsGrim @MiszczuZPolski @YetheSamartaka