Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the format #13

Open
dongxulee opened this issue Feb 2, 2018 · 2 comments
Open

Question about the format #13

dongxulee opened this issue Feb 2, 2018 · 2 comments

Comments

@dongxulee
Copy link

Instead of working on the Jupyter notebook, we work on .py file, so I don't quit understand what kind of format are you exactly looking for, by looking at the modification you made on my code, I just get the general idea. So is there sample files for the format of function, document, test function, protocol for the naming of the function? And can you tell me what is the problem why I can't pass the Travis test? I know part of the reason is the format, and then I find some compiling error. And also about the repo, I think I have trouble understanding every part of it, do I need to know everything to get started, or I just need to know part of it? And what is the most urgent task for now?

@JunhaoWang
Copy link
Owner

  1. the general idea I have is to have a python package that can be installed by anyone using simple "pip install ...", and this package is able to get data, train agent, and simulate trading with real or fake data

  2. it is fine to play with jupyter notebooks but I never had good experience developing a long-term project with it, since it is essentially a prototyping tool. also it is fine to experiment algorithm with jupyter notebook but commit new ideas to testable code in a package setting.

  3. it is impossible and unnecessary to know everything about the repo since our code that matters lives only in src/bittrade and tests/ and those are the only two repos you need to worry about, I ll take care of the rest

  4. the most urgent task is literature and project review and see what is done already by people. feel free to use this google doc to track progress.

  5. I will write utility functions on the side, such as calculating stats from data you retrieved.

@dongxulee
Copy link
Author

How about the format and why I could not pass the test of Travis? What is Travis testing besides the format?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants